Adaptation du template de convention pour l'outre mer #2092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added vocal reading to profile header buttons (10.2 RGAA ticket) * added vocal reading for global menu header (11.1 RGAA ticket) * added RGAA compliance for page 16 (31.x RGAA tickets) * added RGAA compliance for page 15 (30.x RGAA tickets) * fixed compliance to RGAA for pages 7 and 11 (22.x + 26.1.1 RGAA tickets) * fix RGAA lack of context for button (page 12) (27.1.1 RGAA ticket)* * fixed wrong description for avenant checkboxes (27.2 RGAA ticket) * added accessibility links in the base layout (10.1 RGAA ticket) * added table names for housing tables (page 13) (28.3 RGAA ticket) * reduce width of number inputs in form_logements page (28.1 RGAA ticket) * adapted page from_operation/add_convention to RGAA (32.1.1 RGAA ticket) * added field requirement indication to page search_for_avenant.html (34.1 RGAA ticket) * added RGAA compliance for recapitulatif page (21.x RGAA tickets) * added RGAA compliance for cadastre page (20.x RGAA tickets) * added RGAA compliance for bailleur page (19.x RGAA tickets) * fix accessibility for cgu page (18.1 RGAA ticket) * made better accessibility for filters for main page (16.x RGAA tickets) * fixed input_upload.html entry for RGAA compliance (15.1.x RGAA tickets) * started adding removal of the virtaulSelect element * added accessibility for comment button (13.7 RGAA ticket) * added accessibility for 'change administration' button (13.4 RGAA ticket) * added accessibility for export list modal (13.3 RGAA ticket) * added accessibility for pagination (13.2 RGAA ticket) * fixed accessibility by adding links to table lines for convention_list and add_convention (13.1 RGAA ticket) * added titles and fixed buttons taht didn't have enough color contrast (7.1 and 9.1 RGAA tickets) * added accessibility for comment modification buttons (15.2 RGAA ticket) * added accessibility for avenants_checkboxes.html (27.3 RGAA ticket) * added new component for search select lists and raplced old ones (13.9, 33.1 RGAA tickets) * started adding responsivity to screen size (8.3 RGAA ticket) * added p tags where they where missing (19.1 RGAA ticket) + fixed small bug where 'or' was showing when it shouldn't * changed page titles (9.1 RGAA ticket) * moved required fields indication above form instead of under + added more context to download upload form (13.6 and 18.3 RGAA tickets) * improved screen reader reading for ANRU false checkbox (21.4 RGAA ticket) * added missing required fields info and changed convention history to an ordered list (13.6 and 22.1.4 RGAA tickets) * fixed responsivity problems for small screens (8.3 RGAA ticket) * added small fixes * changed colors for elements that did not have enough color contrast (7.1 RGAA ticket) * small changes * Fix pre-commit hook issues * unified search select components that only differed by their entry parameters * started fixing SonarQube issues * continued fixing SonarQube issues * RGAA report and SOnarQube contradicting each others (made RGAA report more important) * removed duplicated lines * removed more duplicated lines * reduced duplicated code bu adding a file for js redirection toward convention * fixed pre commit hooks
Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
* feat: include mixte conventions * mise à jour des templates de generation des conventions mixtes (#2062) --------- Co-authored-by: Ayoub BOUCHACHIA <[email protected]> Co-authored-by: adrien.abescat <[email protected]>
Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
…pull request (#2069) Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
* financement : mise à jour des règles de gestion pour les conventions mixtes - Attribution d’un numéro unique par financement - Obligation de renseigner au moins un organisme financeur (CDCF ou CDCL) pour chaque financement - Durée de conventionnement = année de signature + durée du prêt le plus long, sans être inférieure à 9 ans * fixup! financement : mise à jour des règles de gestion pour les conventions mixtes - Attribution d’un numéro unique par financement - Obligation de renseigner au moins un organisme financeur (CDCF ou CDCL) pour chaque financement - Durée de conventionnement = année de signature + durée du prêt le plus long, sans être inférieure à 9 ans * fix logements and financement * vérifier le financement dans annexe * validation stationnements --------- Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
* changed files that could not be merged for them to be RGAA compliant * fixed convention header * fixed borders of checkboxes disapearing when zooming out
… à regrouper (#2077) Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
* pre commit hooks modifications * added requested changes --------- Co-authored-by: allegal <[email protected]>
Co-authored-by: adrien.abescat <[email protected]>
Co-authored-by: Ayoub BOUCHACHIA <[email protected]>
* started fixing RGAA compliance errors * started fixing SOnarQube errors * kept fixing SonarQube reliability issues * replaced window by globalThis
* pre commit hooks * pre-commit hooks * tried to fix bug of research that disspears between two pages (unsuccesful) * pre commit hooks * temp commit * finished and fixed multiselect component * fixed css commented code * removed commented code
Co-authored-by: adrien.abescat <[email protected]>
Removed pull_request trigger for recette branch.
Co-authored-by: adrien.abescat <[email protected]>
…cel (#2089) * solution pour ajout de logement implementée * gestion de l erreur suite au mauvais financement --------- Co-authored-by: adrien.abescat <[email protected]>
Ayoub-BOUCHACHIA
requested review from
adrien202 and
kolok
and removed request for
a team and
kolok
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
Ayoub-BOUCHACHIA
force-pushed
the
recette
branch
from
e6ca804 to
954c926
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description succincte du problème résolu
Carte Airtable / Lien Mattermost : modèle convention Guyane ne semble plus correspondre
Sur l’opération 2025DD97300036, le modèle de convention générée ne semble pas être le bon (word en pj)
Pour exemple un autre modèle avait été généré sur l’opération 2019DD9730022 et semble convenir. (pdf en pj)
N'oublier pas de taguer :
bug,enhancement,documentation,technical,dependencies(+escalation,regressionsi besion)Auto-review
Les trucs à faire avant de demander une review :
.env.templateComment tester
En local / staging :