-
Notifications
You must be signed in to change notification settings - Fork 13
chore!: renaming country to geoZone and zone to worldRegion
#1564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
1e066fe to
b12cefc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just preliminary remarks with the geoZone name, which could just be geozone and solves a lot of headaches wrt naming conventions across codebases. worldRegion could also be just region imho, but I won't die on this other hill. More broadly, even if I understand we can't use a same single concept and type for "any scale geographic location", I fear the two names — geo zone and world region — might be quite confusing to end-users and documentation readers… though I don't have much better suggestions to offer. What would prevent us to use a single concept and type? (I'm asking the question because I didn't spend the necessary time to investigate the matter yet am offering others to chime in, and I'm definitely part of the ones who should be involved answering that question)
docker/server-simple.js
Outdated
|
|
||
| // Redirects: API | ||
| api.get(/^\/countries$/, (_, res) => res.redirect("textile/countries")); | ||
| api.get(/^\/geo-zones$/, (_, res) => res.redirect("textile/geo-zones")); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same, I could live with just geozones just totally fine.
@n1k0 I’m even wondering if the 'geo' part is necessary after all… Couldn’t we go with just About worldRegions (previously named That won’t be the end of the road, in the codebase, we also have “locations”, with their own semantic, coming from Brightway, “geographicOrigin”, with its own classification, “defaultOrigin”, with another classification, and probably others ? Baby steps… 😆 |
c3fbdab to
446627d
Compare
223e1ac to
e4eade1
Compare
🔧 Problem
Fixes #1532
See also: MTES-MCT/ecobalyse-data#179