Haie / Sites protégés (1/3) #932
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyDez
requested review from
numahell and
thibault
and removed request for
numahell
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
thibault
reviewed
Jan 5, 2026
| return None | ||
|
|
||
|
|
||
| class HedgesCentricMapFactory(MapFactory): |
Collaborator
There was a problem hiding this comment.
J'ai l'impression qu'il y a pas mal de code en commun entre HedgesCentricMapFactory et HedgesToRemoveCentricMapFactory ?
Collaborator
Author
There was a problem hiding this comment.
Ca donne effectivement un peu cette impression, mais il y a de subtiles differences qui rendent la factorisation délicate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/WWIftahm/2018-haie-sites-prot%C3%A9g%C3%A9s-1-3