Skip to content

Conversation

@samueldurante
Copy link
Collaborator

@samueldurante samueldurante commented Jan 7, 2026

https://trello.com/c/gb966vrO

Petit loupé pour la page https://haie.incubateur.net/projet/KMXGZQ/consultation/, quand on n'est pas connecté on voit les infos pour l'instructeur.

Je n'ai pas testé le rendu en local, j'espère ne rien avoir oublié dans les ifs :

  • is_instructor : j'ai mis le code actuel de mep d'hier et supprimé le bouton "contacter le guichet unique"
  • elif is_authenticated : j'ai tout enlevé, on a directement le résultat du simulateur
  • else (guest) : j'ai remis le code d'avant.

Désolé pour ce loupé !

@tristanrobert
Copy link

tristanrobert commented Jan 7, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@numahell numahell force-pushed the hotfix/simu-alter-text branch from 1906f05 to d7c57b2 Compare January 7, 2026 10:03
@numahell numahell changed the title hotfix: change text on petition_project view for unbauthenticated users Hotfix / change text on petition_project view for unbauthenticated users Jan 7, 2026
@numahell numahell requested review from pyDez and thibault and removed request for thibault January 7, 2026 10:27
@numahell numahell force-pushed the hotfix/simu-alter-text branch from bd55d98 to 7c7fa71 Compare January 7, 2026 11:02
@numahell numahell requested a review from thibault January 7, 2026 12:47
Copy link
Collaborator

@pyDez pyDez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Je n'ai pas testé le rendu en local, j'espère ne rien avoir oublié dans les ifs"

Je ne suis pas sur de comprendre ? Tu n'as jamais executé le code ?
Une revue statique du code ne sera jamais suffisante pour le valider à mes yeux.

Co-authored-by: Pierre-Yves Dezaunay <[email protected]>
Copy link
Collaborator

@thibault thibault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok pour moi, merci @numahell

Co-authored-by: Thibault J. <[email protected]>
@numahell numahell merged commit 326b28f into main Jan 8, 2026
9 checks passed
@numahell numahell deleted the hotfix/simu-alter-text branch January 8, 2026 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants