-
Notifications
You must be signed in to change notification settings - Fork 7
Hotfix / change text on petition_project view for unbauthenticated users #944
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
1906f05 to
d7c57b2
Compare
bd55d98 to
7c7fa71
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Je n'ai pas testé le rendu en local, j'espère ne rien avoir oublié dans les ifs"
Je ne suis pas sur de comprendre ? Tu n'as jamais executé le code ?
Une revue statique du code ne sera jamais suffisante pour le valider à mes yeux.
Co-authored-by: Pierre-Yves Dezaunay <[email protected]>
thibault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok pour moi, merci @numahell
Co-authored-by: Thibault J. <[email protected]>
https://trello.com/c/gb966vrO
Petit loupé pour la page https://haie.incubateur.net/projet/KMXGZQ/consultation/, quand on n'est pas connecté on voit les infos pour l'instructeur.
Je n'ai pas testé le rendu en local, j'espère ne rien avoir oublié dans les ifs :
Désolé pour ce loupé !