[AIS] [UPDATE DB_VERSION] Création de la table ais_positions, stockage des positions #2658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
maximeperraultdev
changed the base branch from
main
to
maxime/tech/setup_kafka_SSL
maximeperraultdev
changed the title
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
9 times, most recently
from
d4c0d48 to
9b546d9
Compare
louptheron
reviewed
Dec 19, 2025
Collaborator
louptheron
left a comment
louptheron
left a comment
There was a problem hiding this comment.
Quelques commentaires
|
|
||
| val messages = mutableListOf<String>() | ||
| companion object { | ||
| const val TOPIC = "monitorenv.ais.position" |
Collaborator
There was a problem hiding this comment.
Peut-être plus pratique d'avoir une variable d'env ?
| ais: | ||
| enabled: ${MONITORENV_KAFKA_AIS_ENABLED} | ||
| producer: | ||
| enabled: ${MONITORENV_KAFKA_AIS_PRODUCER_ENABLED} |
Collaborator
There was a problem hiding this comment.
Autant mettre une valeur par défaut à false comme ça ne sera pas utilisé en prod ?
Collaborator
Author
There was a problem hiding this comment.
Normalement la valeur de prod est dans le fichier .env. J'ai ajouté un :false comme ça on est tranquille ^^
| @KafkaListener(topics = [TOPIC]) | ||
| fun listenAIS(payload: AISPayload) { | ||
| try { | ||
| jpaAISPositionRepository.save(payload) |
Collaborator
There was a problem hiding this comment.
Utilise un BlockingQueue pour éviter d'avoir une trnsaction SQL à chaque réception de message ? Commencer par un batch de 100 par exemple ?
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
from
22b152a to
4e5a95a
Compare
maximeperraultdev
changed the title
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
from
35b180a to
4aea323
Compare
maximeperraultdev
changed the base branch from
maxime/tech/setup_kafka_SSL
to
main
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
3 times, most recently
from
a5a6e50 to
06edefa
Compare
…o rework producer for testing.
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
from
06edefa to
a71716c
Compare
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
from
a71716c to
ffba86d
Compare
maximeperraultdev
force-pushed
the
maxime/feat/2611/setup_AIS_storage
branch
from
3c23f1e to
9688d31
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Pull Requests & Issues