-
Notifications
You must be signed in to change notification settings - Fork 1
feat(dpe): add analysis tools and improve DPE import logic #1471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9429425 | Triggered | Generic Password | 36c39ba | server/src/scripts/import-dpe/analyze_dpe_distribution.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
9bbf561 to
36c39ba
Compare
Update test file to use new method signature with `existing_dpe_id` and `building` parameters instead of the old `existing_dpe` dict.
|
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #1471 +/- ##
===========================================
- Coverage 63.61% 35.16% -28.46%
===========================================
Files 356 4 -352
Lines 21734 1166 -20568
Branches 2048 0 -2048
===========================================
- Hits 13826 410 -13416
+ Misses 7875 756 -7119
+ Partials 33 0 -33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|



Add comprehensive analysis scripts and improve DPE import to support updating existing buildings with newer DPE data.
Analysis tools:
quarterly breakdown, BAN address matching analysis, and PDF reports
Import improvements:
Analysis features:
This addresses the low 2025 DPE import rate (0.6%) by:
but only ~45% match the ban_addresses table in production