Mise en production 08/01/2026 #1541
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrate user type information from Portail DF API to categorize users as 'prestataire', 'gestionnaire', or both. - Add kind field to users table (migration) - Fetch user type from Portail DF during authentication and user creation - Add userKindService to handle Portail DF API integration - Add sync script to update existing users - Update user models to include kind field
Add the missing 'kind' property (string | null) to genUserDTO fixture to match the updated UserDTO interface. Fixes TypeScript compilation error: Property 'kind' is missing in type but required in type 'UserDTO'.
Add the missing 'kind' property throughout the codebase: - userRepository: Add kind to UserDBO interface and parsing functions - accountController: Fix void return type issue from userRepository.update() - seeds: Add kind: null to production and development user fixtures - userKindService: Fix type assertion for API response - fixtures: Add kind: null to genUserDTO All TypeScript compilation errors resolved.
Add the 'kind' field to: - fromUserDTO and toUserDTO functions in frontend - User mock handler - GroupApi test assertions
- Add multipart/form-data authentication to sync_user_kind.py script - Add --username and --password CLI arguments for API credentials - Implement retry with exponential backoff for API timeouts (3 retries) - Increase API timeout to 30s for individual requests, 60s for auth - Fix UUID cast in SQL update query (user_id::uuid) - Update userKindService.ts to use FormData for authentication
The API requires token authentication instead of basic auth. Added --username and --password as required arguments and implemented token retrieval via /api-token-auth/ endpoint.
- Add BATCH_SIZE limit and batchedWhereIn helper to events seed to avoid PostgreSQL parameter limit being exceeded with large datasets - Add config.cerema.enabled check in fetchUserKind to skip API calls when Cerema integration is disabled
Create updatedUser object once and reuse it for both userRepository.update() and subsequent operations. Addresses review comment from @Falinor about duplicated code.
…sers feat(users): add user type classification from Portail DF
Contributor
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…sions Add empty option to precisions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.