Skip to content

Commit b4d8dac

Browse files
committed
[DOP-28389] Improve group member role check
1 parent ca6f106 commit b4d8dac

2 files changed

Lines changed: 6 additions & 6 deletions

File tree

syncmaster/db/repositories/queue.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@ async def get_group_permission(self, user: User, group_id: int) -> Permission:
114114
if not user_group:
115115
return Permission.NONE
116116

117-
if user_group == GroupMemberRole.Maintainer:
117+
if user_group.role == GroupMemberRole.Maintainer:
118118
return Permission.DELETE
119119

120120
return Permission.READ
@@ -165,7 +165,7 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
165165
if not user_group:
166166
return Permission.NONE
167167

168-
if user_group == GroupMemberRole.Maintainer:
168+
if user_group.role == GroupMemberRole.Maintainer:
169169
return Permission.DELETE
170170

171171
return Permission.READ

syncmaster/db/repositories/repository_with_owner.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ async def get_resource_permission(self, user: User, resource_id: int) -> Permiss
5656
if not user_group:
5757
return Permission.NONE
5858

59-
if user_group == GroupMemberRole.Maintainer:
59+
if user_group.role == GroupMemberRole.Maintainer:
6060
return Permission.DELETE
6161

62-
if user_group == GroupMemberRole.Developer:
62+
if user_group.role == GroupMemberRole.Developer:
6363
return Permission.WRITE
6464

6565
return Permission.READ
@@ -96,10 +96,10 @@ async def get_group_permission(self, user: User, group_id: int) -> Permission:
9696
if not user_group:
9797
return Permission.NONE
9898

99-
if user_group == GroupMemberRole.Maintainer:
99+
if user_group.role == GroupMemberRole.Maintainer:
100100
return Permission.DELETE
101101

102-
if user_group == GroupMemberRole.Developer:
102+
if user_group.role == GroupMemberRole.Developer:
103103
return Permission.WRITE
104104

105105
return Permission.READ

0 commit comments

Comments
 (0)