feature/91-add-main-view-model #99
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| package com.washingtondcsquad.tudee | ||
|
|
||
| import java.util.Locale | ||
|
|
||
| data class MainState( | ||
|
Collaborator
There was a problem hiding this comment. name of this data class shouble be MainActivityScreenState but MainState is inConsistent and not the convention for naming screen state |
||
| val isDarkTheme: Boolean = false, | ||
| val hasOnBoardingShown: Boolean? = null, | ||
|
kareem-01 marked this conversation as resolved.
Outdated
Collaborator
There was a problem hiding this comment. i don't see any need of nullable value for hasOnBoardingShow, because it must be initialize when the app start |
||
| val currentAppLocale: Locale = Locale.ENGLISH | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| package com.washingtondcsquad.tudee | ||
|
|
||
| import androidx.lifecycle.viewModelScope | ||
| import com.washingtondcsquad.tudee.domain.services.AppPreferencesService | ||
| import com.washingtondcsquad.tudee.presentation.base.BaseViewModel | ||
| import kotlinx.coroutines.flow.Flow | ||
| import kotlinx.coroutines.flow.collectLatest | ||
| import kotlinx.coroutines.launch | ||
| import java.util.Locale | ||
|
|
||
| class MainViewModel( | ||
|
Collaborator
There was a problem hiding this comment. i suggest to rename this to MainActivityViewModel
kareem-01 marked this conversation as resolved.
|
||
| private val appPreferencesService: AppPreferencesService | ||
| ) : BaseViewModel<MainState>(MainState()) { | ||
|
|
||
| init { | ||
| getIsDarkTheme() | ||
| getOnBoardingState() | ||
|
Collaborator
There was a problem hiding this comment. same as the above method |
||
| getAppLocale() | ||
| } | ||
|
|
||
| private fun getIsDarkTheme() { | ||
|
kareem-01 marked this conversation as resolved.
|
||
| tryToExecute( | ||
| request = { | ||
| appPreferencesService.isDarkModeEnabled() | ||
|
kareem-01 marked this conversation as resolved.
|
||
| }, | ||
| onSuccess = ::onDarkThemeEnabled, | ||
| onError = {} | ||
|
Collaborator
There was a problem hiding this comment. i think it always a good practice to handle error state, help in debugging and improve user experience |
||
| ) | ||
| } | ||
|
|
||
| private fun onDarkThemeEnabled(isDarkThemeEnabled: Flow<Boolean>) = viewModelScope.launch { | ||
| isDarkThemeEnabled.collectLatest { | ||
| updateState { | ||
| copy(isDarkTheme = it) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun getOnBoardingState() { | ||
| tryToExecute( | ||
| request = { | ||
| appPreferencesService.hasOnboardingBeenShown() | ||
| }, | ||
| onSuccess = ::onOnBoardingState, | ||
| onError = {} | ||
| ) | ||
| } | ||
|
|
||
| private fun onOnBoardingState(hasOnboardingBeenShown: Flow<Boolean>) = viewModelScope.launch { | ||
| hasOnboardingBeenShown.collectLatest { | ||
| updateState { | ||
| copy(hasOnBoardingShown = it) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| private fun getAppLocale() { | ||
| tryToCollect( | ||
| request = { | ||
| appPreferencesService.getCurrentLocale() | ||
| }, | ||
| onChange = ::onAppLanguageChanged, | ||
| onError = {}, | ||
| ) | ||
| } | ||
|
|
||
| private fun onAppLanguageChanged(newLocale: Locale) { | ||
| updateState { | ||
| copy(currentAppLocale = newLocale) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| package com.washingtondcsquad.tudee.presentation.utils | ||
|
|
||
| import androidx.compose.foundation.layout.padding | ||
| import androidx.compose.material3.SnackbarDuration | ||
| import androidx.compose.material3.SnackbarHost | ||
| import androidx.compose.material3.SnackbarHostState | ||
| import androidx.compose.runtime.Composable | ||
| import androidx.compose.runtime.remember | ||
| import androidx.compose.runtime.rememberCoroutineScope | ||
| import androidx.compose.ui.Modifier | ||
| import androidx.compose.ui.res.painterResource | ||
| import androidx.compose.ui.unit.dp | ||
| import com.washingtondcsquad.tudee.R | ||
| import com.washingtondcsquad.tudee.presentation.components.SnackBarCard | ||
| import com.washingtondcsquad.tudee.presentation.components.snack_bar.ObserveAsEvent | ||
| import com.washingtondcsquad.tudee.presentation.components.snack_bar.SnackbarController | ||
| import com.washingtondcsquad.tudee.presentation.design.AppTheme | ||
| import kotlinx.coroutines.launch | ||
|
|
||
| @Composable | ||
| fun SnackBarHandler() { | ||
| val snackBarHostState = remember { SnackbarHostState() } | ||
| val coroutineScope = rememberCoroutineScope() | ||
| ObserveAsEvent( | ||
| flow = SnackbarController.event, | ||
| onEvent = { event -> | ||
| coroutineScope.launch { | ||
| snackBarHostState.currentSnackbarData?.dismiss() | ||
| snackBarHostState.showSnackbar( | ||
| message = event.message, | ||
| duration = SnackbarDuration.Short | ||
| ) | ||
| } | ||
| } | ||
| ) | ||
|
|
||
| SnackbarHost( | ||
| hostState = snackBarHostState, | ||
| snackbar = { snackbarData -> | ||
| val (iconRes, iconTint) = when { | ||
| snackbarData.visuals.message.contains("success", ignoreCase = true) -> | ||
| Pair(R.drawable.checkmark, AppTheme.colors.greenAccent) | ||
|
|
||
| snackbarData.visuals.message.contains("error", ignoreCase = true) -> | ||
| Pair(R.drawable.checkmark, AppTheme.colors.error) | ||
|
|
||
| else -> | ||
| Pair(R.drawable.information_diamond, AppTheme.colors.error) | ||
| } | ||
|
|
||
| SnackBarCard( | ||
| message = snackbarData.visuals.message, | ||
| icon = painterResource(id = iconRes), | ||
| iconTint = iconTint, | ||
| iconBackgroundColor = AppTheme.colors.surface, | ||
| modifier = Modifier.padding(horizontal = 8.dp, vertical = 48.dp) | ||
| ) | ||
|
|
||
| } | ||
| ) | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.