Skip to content

Suppress unused warnings for logged variables #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cleishm wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Suppress unused warnings for logged variables #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions src/ESP32RotaryEncoder.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,14 @@
#endif
#endif

#if __cplusplus >= 201703L
#define MAYBE_UNUSED [[maybe_unused]]
#elif defined( __GNUC__ ) || defined( __clang__ )
#define MAYBE_UNUSED __attribute__((unused))
#else
#define MAYBE_UNUSED
#endif

RotaryEncoder::RotaryEncoder( uint8_t encoderPinA, uint8_t encoderPinB, int8_t buttonPin, int8_t vccPin, uint8_t encoderSteps )
: encoderPinA{ encoderPinA },
encoderPinB{ encoderPinB },
Expand Down Expand Up @@ -258,7 +266,7 @@ bool RotaryEncoder::buttonPressed()
}

bool wasPressed;
unsigned long duration;
MAYBE_UNUSED unsigned long duration;

portENTER_CRITICAL( &mux );
wasPressed = buttonPressedFlag;
Expand All @@ -279,7 +287,7 @@ bool RotaryEncoder::encoderChanged()
}

bool hasChanged;
long value;
MAYBE_UNUSED long value;

portENTER_CRITICAL( &mux );
hasChanged = encoderChangedFlag;
Expand Down