Skip to content

Resolved view image bug #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deepjoshi94 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Resolved view image bug #117

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions Block/SliderItem.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@

use Magestore\Bannerslider\Model\Slider as SliderModel;
use Magestore\Bannerslider\Model\Status;
use Magento\Cms\Model\Template\FilterProvider;

/**
* Slider item.
Expand Down Expand Up @@ -112,6 +113,13 @@ class SliderItem extends \Magento\Framework\View\Element\Template
* @var \Magento\Framework\Stdlib\DateTime\Timezone
*/
protected $_stdTimezone;

/**
* filter provider
*
* @var \Magento\Cms\Model\Template\FilterProvider
*/
protected $_filterProvider;

/**
* [__construct description].
Expand All @@ -134,6 +142,7 @@ public function __construct(
\Magento\Framework\Stdlib\DateTime\DateTime $stdlibDateTime,
\Magestore\Bannerslider\Helper\Data $bannersliderHelper,
\Magento\Framework\Stdlib\DateTime\Timezone $_stdTimezone,
FilterProvider $filterProvider,
array $data = []
) {
parent::__construct($context, $data);
Expand All @@ -144,6 +153,7 @@ public function __construct(
$this->_bannerCollectionFactory = $bannerCollectionFactory;
$this->_scopeConfig = $context->getScopeConfig();
$this->_stdTimezone = $_stdTimezone;
$this->_filterProvider = $filterProvider;
}

/**
Expand Down Expand Up @@ -305,4 +315,13 @@ public function getFlexsliderHtmlId()
{
return 'magestore-bannerslider-flex-slider-'.$this->getSlider()->getId().$this->_stdlibDateTime->gmtTimestamp();
}

/**
*
* format image
* @return string
*/
public function formatCaption($content) {
return $this->_filterProvider->getPageFilter()->filter($content);
}
}
4 changes: 2 additions & 2 deletions view/frontend/templates/slider/flexslider.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,15 +132,15 @@ $bannerCollection = $block->getBannerCollection();
<a href="<?php echo $banner->getClickUrl() ?>" target="<?php echo $banner->getTargetValue() ?>" style="display:block;" data-mage-init='{"magestore/clickbanner": {"url": "<?php echo $this->getUrl("bannerslider/index/click") ?>", "slider_id": "<?php echo $banner->getSliderId() ?>", "banner_id": "<?php echo $banner->getId() ?>" }}' >
<img alt="<?php echo $banner->getImageAlt() ?>" src="<?php echo $block->getBannerImageUrl($banner) ?>"/>
</a>
<?php if($banner->getCaption()): ?><div class="flex-caption"><?php echo $banner->getCaption(); ?></div><?php endif; ?>
<?php if($banner->getCaption()): ?><div class="flex-caption"><?php echo $block->formatCaption($banner->getCaption()) ?></div><?php endif; ?>
</li>
<?php else :
?>
<li>
<a href="<?php echo $banner->getClickUrl() ?>" target="<?php echo $banner->getTargetValue() ?>" style="display:block;" data-mage-init='{"magestore/clickbanner": {"url": "<?php echo $this->getUrl("bannerslider/index/click") ?>", "slider_id": "<?php echo $banner->getSliderId() ?>", "banner_id": "<?php echo $banner->getId() ?>" }}' >
<img alt="<?php echo $banner->getImageAlt() ?>" src="<?php echo $block->getBannerImageUrl($banner) ?>"/>
</a>
<?php if($banner->getCaption()): ?><div class="flex-caption"><?php echo $banner->getCaption(); ?></div><?php endif; ?>
<?php if($banner->getCaption()): ?><div class="flex-caption"><?php echo $block->formatCaption($banner->getCaption()) ?></div><?php endif; ?>
</li>
<?php endif; ?>
<?php endforeach ?>
Expand Down