Update loop task factory typing with kwargs #585
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #584
For
PY311the task factory will be called with the context kwarg. This is not correctly reflected in the typing forLoop.set_task_factoryandLoop.get_task_factory.This commit addresses this with a protocol. Since
uvlooprequires a minimum Python 3.8 version, in whichtyping.Protocolis available. Note, neithertyping.Unpackfor kwargs, (introduced in Python 3.11) ortyping.ParmSpecwithParamSpec.kwargs(introduced in Python 3.10) is available for 3.8Did not explicitly type the
contextparameter and used**kwargssince the Loop method allows for the legacy API without a context param for<PY311Also see discussion about
nameparameter for task factory in asyncio: python/cpython#112623 (comment)Quick demonstration of typing (see mypy Callback Protocols)