Skip to content

Conversation

@Code0x58
Copy link

@Code0x58 Code0x58 commented Oct 15, 2017

Here are a few fixes that I needed to get the code running smoothly locally:

  • disable caching while building
  • update uvloop version so there isn't an exception caused by a missing module/member in the containers
  • hammer away at the docker container to make sure it has stopped before another one tries to start
  • make sure only one type of benchmark is running at a time so the HTML formatting doesn't blow up, seemed reasonable (and simpler) to add a constraint
  • nice to have updated kbKiB as kb wasn't kilobits
  • useful updated README.md to give versions for the required software that are known to work (including wrk which wasn't listed), and added a working example of run_benchmarks

@Code0x58 Code0x58 force-pushed the master branch 3 times, most recently from c32589a to ab84058 Compare October 16, 2017 19:58
@Code0x58
Copy link
Author

poke is this satisfactory now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants