fix!: support dynamic NodePorts by making ports optional/removing default #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrPsychick
force-pushed
the
dynamic-nodeports
branch
from
7936484 to
1e7978d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is possibly a breaking change, as current users must define the NodePort ports for the helm chart to work. If they don't the defaults are used (NodePorts < 30000).
Kubernetes uses dynamic NodePorts above 30000 by default, but for that, the NodePort may not be specified. This change allows for that by not setting a default NodePort.
Additionally fixes a "readme-generator" version mismatch between pre-commit and GitHub workflow. The workflow now also uses "pre-commit", so versions always match.