Add miq data table commands #9691
Conversation
cypress/support/commands/gtl.js
Outdated
|
|
||
| Cypress.Commands.add('gtl_no_record', () => { | ||
| return cy.get('#miq-gtl-view > div.no-record').should('be.visible'); | ||
| Cypress.Commands.add('verify_gtl_no_records_text', ({ containsText = 'No records' } = {}) => { |
There was a problem hiding this comment.
Not sure if this might be better under assertion commands(cypress/support/assertions/)
There was a problem hiding this comment.
good idea.... looks like it follows expect_* convention. Maybe expect_gtl_no_records_with_text or having_text... I think you use with text more commonly elsewhere.
There was a problem hiding this comment.
Going with expect_gtl_no_records_with_text 👍
asirvadAbrahamVarghese
force-pushed
the
add-miq-data-table-commands
branch
2 times, most recently
from
aec3e33 to
acf0295
Compare
| if (columnIndex || columnIndex === 0) { | ||
| cy.contains(`.miq-data-table table tbody tr td:nth-child(${columnIndex + 1})`, text).click(); | ||
| } else { | ||
| cy.contains('.miq-data-table table tbody tr td', text).click(); |
There was a problem hiding this comment.
👍 It's good to be case sensitive here and expect exact text since we'll be creating the objects with the right text so it should be easy to ensure we match it correctly.
It will be interesting to see if this miq-data-table structure holds for all pages containing the data table. I hope so but we'll see as we do more pages.
There was a problem hiding this comment.
Yeah, I had the same doubt, that’s why I’m keeping the selector minimal(without including classes) for now. Let’s see how it goes....
asirvadAbrahamVarghese
force-pushed
the
add-miq-data-table-commands
branch
from
acf0295 to
3ffa5fc
Compare
3 participants
PR to:
no-recordclass as selector, but here ⬇️ it usesno-records-found. To make the assertion more reliable, I removed the class from the selector and switched to asserting based on the visible text instead.Also not sure if this might be better under assertion commands(
cypress/support/assertions/)@miq-bot add-label cypress
@miq-bot add-label enhancement
@miq-bot assign @jrafanie