Skip to content

Performance improvements to MiqProvisionVirtWorkflow#allowed_templates #18353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 19, 2019
Merged

Performance improvements to MiqProvisionVirtWorkflow#allowed_templates #18353

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
32be9ec
[miq_provision_virt_workflow.rb] Skip debug loop
NickLaMuro Jan 4, 2019
0bf7d87
[miq_provision_virt_workflow.rb] Limit .preload
NickLaMuro Jan 4, 2019
c75af75
[miq_provision_virt_workflow.rb] Delay HashStruct gen
NickLaMuro Jan 9, 2019
c8cc799
[miq_provision_virt_workflow.rb] Use EMS cache
NickLaMuro Jan 9, 2019
69c94ad
[miq_provision_virt_workflow.rb] Specify vm cols
NickLaMuro Jan 9, 2019
f83c69f
[miq_provision_virt_workflow.rb] Avoid respond_to?
NickLaMuro Jan 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/models/miq_provision_virt_workflow.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ def allowed_templates(options = {})
end

# Only select the colums we need
vms = vms.select(:id, :name, :guid, :uid_ems, :ems_id)
vms = vms.select(:id, :name, :guid, :uid_ems, :ems_id, :cloud_tenant_id)

allowed_templates_list = source_vm_rbac_filter(vms, condition, VM_OR_TEMPLATE_EXTRA_COLS).to_a
@allowed_templates_filter = filter_id
Expand Down Expand Up @@ -1046,7 +1046,7 @@ def create_hash_struct_from_vm_or_template(vm_or_template, options)
:allocated_disk_storage => vm_or_template.allocated_disk_storage,
:v_total_snapshots => vm_or_template.v_total_snapshots,
:evm_object_class => :Vm}
data_hash[:cloud_tenant] = vm_or_template.cloud_tenant if vm_or_template.respond_to?(:cloud_tenant)
data_hash[:cloud_tenant] = vm_or_template.cloud_tenant if vm_or_template.cloud_tenant_id
if vm_or_template.operating_system
data_hash[:operating_system] = MiqHashStruct.new(:product_name => vm_or_template.operating_system.product_name)
end
Expand Down