Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump sprockets from 3.7.2 to 4.0.0 #4255

Merged
merged 3 commits into from
Dec 9, 2019

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Dec 1, 2019

Bumps sprockets from 3.7.2 to 4.0.0.

Changelog

Sourced from sprockets's changelog.

4.0.0

  • Fixes for Ruby 2.7 keyword arguments warnings #625
  • Manifest files are sorted alphabetically #626

4.0.0.beta10

4.0.0.beta9

  • Minimum Ruby version for Sprockets 4 is now 2.5+ which matches minimum ruby verision of Rails #604
  • Fix threading bug introduced in Sprockets 4 #603
  • Warn when two potential manifest files exist. #560

4.0.0.beta8

4.0.0.beta7

  • Fix a year long bug that caused Sprockets::FileNotFound errors when the asset was present #547
  • Raise an error when two assets such as foo.js and foo.js.erb would produce the same output artifact (foo.js) [MarkUs API should support multiple formats #549 #530]
  • Process *.jst.eco.erb files with ERBProcessor

4.0.0.beta6

  • Fix source map line offsets #515
  • Return a 400 Bad Request when the path encoding is invalid. #514

4.0.0.beta5

  • Reduce string allocations
  • Source map metadata uses compressed form specified by the source map v3 spec. #402 [BREAKING]
  • Generate index maps when decoding source maps isn't necessary. #402
  • Remove fingerprints from source map files. #402

4.0.0.beta4

  • Changing the version now busts the digest of all assets #404
  • Exporter interface added #386
  • Using ENV vars in templates will recompile templates when the env vars change. #365
  • Source maps for imported sass files with sassc is now fixed #391
  • Load paths now in error messages #322
  • Cache key added to babel processor #387
  • Environment#find_asset! can now be used to raise an exception when asset could not be found #379

4.0.0.beta3

... (truncated)
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code labels Dec 1, 2019
@dependabot-preview dependabot-preview bot force-pushed the dependabot/bundler/sprockets-4.0.0 branch from 6a4747a to 1b38f12 Compare December 6, 2019 22:18
@mishaschwartz mishaschwartz force-pushed the dependabot/bundler/sprockets-4.0.0 branch from 1b38f12 to 50b873b Compare December 6, 2019 22:36
@mishaschwartz
Copy link
Contributor

mishaschwartz commented Dec 6, 2019

Removing:

config.assets.precompile = %w(manifest.js)

because it is loaded by default already (https://github.com/rails/sprockets/blob/master/UPGRADING.md#manifestjs)

and loading it a second time causes a segfault: rails/sprockets#633

@mishaschwartz
Copy link
Contributor

I'm not entirely sure why, but it seems that we need to specify the converted file extension, not the file extension of the source file.

For example, SyntaxHighlighter.scss gets converted to SyntaxHighlighter.css so in manifest.js we need to specify the css version.

See this blog post for some explanations/speculations.

@mishaschwartz mishaschwartz merged commit 07064fc into master Dec 9, 2019
@dependabot-preview dependabot-preview bot deleted the dependabot/bundler/sprockets-4.0.0 branch December 9, 2019 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant