added colors

[TvL2386]

No description provided.

[MarsEdge]

I'm quite elated that someone is actually using my code. I haven't seen much use and this is a welcome surprise. Sadly, I'm mostly retired from GW2 such that I cannot test this. Since I can't test it.... I can't confidently merge it. My website is now down, but my post about stopping development can be found here

That being said, a couple things stand out.

The profession colors appear hardcoded. arcdps has an api for getting the colors used in the arcdps UI settings. I'd encourage using that over separate hardcoded values.

It looks like you're using a newer version of Visual Studio. That not a big deal, but it should probably not be in this PR.

Changing how the hash is made(and/or location of GW2-64.exe) also makes sense for you, but not for this PR.

You probably don't want to do custom patches to imgui itself. I use a very specific version that is also used by arcdps. You'd want to make a separate function that does what you want. I'm actually somewhat surprised this works at all given that the arcdps imgui context is the one that ends up running everything.

The profession colors don't appear to be optional, yet you removed a TODO saying 'add optional profession colors'

I don't really know what to say. I don't feel comfortable merging it(even if/when the above are fixed), but if you want to fork the project and start doing things yourself.... go for it. I'm happy to answer questions about the code. You can also find me/other knowledgeable people in the Elite Insights discord

I'll leave the PR open so others will see it.

[TvL2386]

Hi MarsEdge,

It seems I accidentally created a pull request when I just wanted to merge it to my master :-)
Sorry for that. I totally agree with all the things you said. This request has much more than would be appropriate to merge and will disrupt your development environment.

I heard that you had retired developing this tool and received a request to "add colors like arcdps". So this is actually my first swing at it (new to C++ and Visual Studio).

I indeed want to use the colors that can be manually set in arcdps, however I didn't see how to get those values from arcdps internally. Feel free to close the pull request when you see fit.

Thanks for the feedback and this awesome tool! :-)