Basic messages with currently buggy support of BBCode#7
Basic messages with currently buggy support of BBCode#7Sulucnal wants to merge 4 commits intoMaruno17:mainfrom
Conversation
NuriYuri
left a comment
NuriYuri
left a comment
There was a problem hiding this comment.
That's a big PR so I will need to come back later for other details. I could not test yet.
| @onready var main : Main = get_tree().root.get_child(-1) | ||
|
|
||
|
|
||
| var last_scene_added : Variant |
There was a problem hiding this comment.
What's the purpose of that variable?
There was a problem hiding this comment.
It is used by the scene manager to add and remove nodes from the main scene.
| await get_tree().create_timer(GlobalVar.milliseconds_per_char).timeout | ||
|
|
||
|
|
||
| func _process(_delta: float) -> void: #I don't like the way it's done but I'm too tired to solve it right now. |
There was a problem hiding this comment.
Don't hesitate to discuss with voxet if you need support on that. They showed a battle video they implemented and there's a message showing in there :)
|
Hi, this PR has code related to that PR: #8 Can you both sync together to make sure each PR does one thing and does not conflict with each other? |
|
Hi :) I see that the PR for Godot 4.4 was merged. Can you attempt to rebase and see how this PR behave in regard of Godot 4.4? (If you have time) |
Regarding that, I have a problem regarding conflicts with this PR: #8. I left them a message but they probably didn't see it or got busy. I'll try to get in contact with them to see if they can either do what I asked of them or let me use a part of their code that handled a problem I had in a better way than what I did. |
|
Ok :) Tell me if you need a decision or something in few days :) |
|
I closed #8 for the lack of answer. |
2 participants
No description provided.