Skip to content

WIP: feat/support decryption key alias #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joseph-neeraj
Copy link
Contributor

PR checklist

  • [ x ] An issue/feature request has been created for this PR
  • [ x ] Pull Request title clearly describes the work in the pull request and the Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response.
  • [ x ] File the PR against the main branch
  • [ x ] The code in this PR is covered by unit tests

Link to issue/feature request: add the link here

Description

  • The README was missing the detail regarding using PKCS12 file directly in the config, instead of the private key. This has been fixed.
  • The lib's json configuration was inconsistent with that of nodejs, nodejs uses keyStore and keyStorePassword for specifying the decryption key, and this lib uses decryptionKey and decryptionKeyPassword. Made these aliases so it's consistent now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant