Skip to content

Conversation

@kwesiRutledge
Copy link
Contributor

The GetObjective() function signature that we require for the solution.Solution interface is not necessary anymore given the existence of the new method: GetOptimalObjectiveValue. Removing the unnecessary getter.

Also, looks like the SymbolicMath.go version wasn't upgraded since v0.2.6. Whoops!

@kwesiRutledge kwesiRutledge requested a review from Copilot October 17, 2025 03:35
@kwesiRutledge kwesiRutledge self-assigned this Oct 17, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated GetObjective() function from the solution.Solution interface and updates the SymbolicMath.go dependency to version v0.3.1. The GetObjective() method is no longer needed since GetOptimalObjectiveValue() now provides this functionality.

Key changes:

  • Removed GetOptimalValue() method from the Solution interface and DummySolution implementation
  • Removed the Objective field from DummySolution struct and all test instantiations
  • Updated SymbolicMath.go dependency from v0.2.6 to v0.3.1

Reviewed Changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

File Description
solution/solution.go Removed GetOptimalValue() method signature from interface and added comprehensive documentation for GetValueMap()
solution/dummy_solution.go Removed Objective field and GetOptimalValue() implementation from DummySolution
testing/solution/solution_test.go Removed Objective field assignments from all test case DummySolution instantiations
go.mod Updated SymbolicMath.go dependency from v0.2.6 to v0.3.1

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.37%. Comparing base (0214315) to head (e02ac4e).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #28      +/-   ##
==========================================
+ Coverage   86.76%   87.37%   +0.61%     
==========================================
  Files          27       35       +8     
  Lines        3687     4183     +496     
==========================================
+ Hits         3199     3655     +456     
- Misses        440      472      +32     
- Partials       48       56       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Improved comment for GetStatus interface method.

Co-authored-by: Copilot <[email protected]>
@kwesiRutledge kwesiRutledge merged commit eccb7e9 into main Oct 17, 2025
5 checks passed
@kwesiRutledge kwesiRutledge deleted the kr/fix/remove-get-objective1 branch October 17, 2025 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants