-
-
Couldn't load subscription status.
- Fork 0
Introducing AsSimplifiedExpression() Requirement to Expression Interface #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… it to fix some of the substitute methods for Polynomials
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #21 +/- ##
==========================================
+ Coverage 87.44% 87.46% +0.02%
==========================================
Files 42 42
Lines 6332 6431 +99
==========================================
+ Hits 5537 5625 +88
Misses 719 719
- Partials 76 87 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Summary
On the course to fixing a bug in MatProGo-dev/simplex, we realized that there was a problem with
(p Polynomial) Substitute. The issue was shared with other polynomial objects.We began to find that the issue could be helped by introducing a proper Simplification method to all expressions to avoid some issues of complicated conversions in the
Polynomialmethods.Introduced the
AsSimplifiedExpression()method to theExpression(and related) interfaces. This should make it much easier (thoughtless really) to simplify.