Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: provide mechanism to override ancestor release #23525

Conversation

nrainer-materialize
Copy link
Contributor

PR#23421 introduced performance and scalability regressions. This will cause nightly builds against 0.78.13+ to fail. This PR introduces a mechanism to provide the merge commit of PR#23421 as ancestor / comparison base when this commit is included in the current state and as long as the next release 0.79.0 (which will contain the PR) is not reached.

This should address the current failures of the feature benchmark and scalability benchmark in nightly#5406, nightly#5411, and subsequent builds until the next major release.

This PR also contains refactorings. Either review commit-wise or focus on commit 034fe03.

@nrainer-materialize nrainer-materialize added the T-testing Theme: tests or test infrastructure label Nov 29, 2023
@nrainer-materialize nrainer-materialize self-assigned this Nov 29, 2023
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nrainer-materialize nrainer-materialize merged commit 8edcc2b into MaterializeInc:main Nov 29, 2023
@nrainer-materialize nrainer-materialize deleted the ci/override-comparison-target branch November 29, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-testing Theme: tests or test infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants