Skip to content

adapter: Changes to get aws_external_connection_role from args #23626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

moulimukherjee
Copy link
Contributor

@moulimukherjee moulimukherjee commented Dec 1, 2023

Adding an argument to accept a Materialize Role ARN in environmentd and setting it in AwsPrincipalContext to be used later for AWS connections #23282

Motivation

Split this PR from #23282, so that this can be merged by 0.79 in case the other one takes longer (and unblock cloud so that they can start passing the materialize role arn).

Corresponding cloud issue: https://github.com/MaterializeInc/cloud/issues/8191

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

cc @jubrad

@moulimukherjee moulimukherjee marked this pull request as ready for review December 1, 2023 23:00
@moulimukherjee moulimukherjee requested a review from a team as a code owner December 1, 2023 23:00
@moulimukherjee moulimukherjee self-assigned this Dec 2, 2023
@moulimukherjee moulimukherjee force-pushed the accept-aws-external-role-arn branch from 2579f89 to d1680ab Compare December 4, 2023 17:08
@moulimukherjee moulimukherjee enabled auto-merge (squash) December 4, 2023 17:08
@moulimukherjee moulimukherjee merged commit a316fc8 into MaterializeInc:main Dec 4, 2023
@moulimukherjee moulimukherjee deleted the accept-aws-external-role-arn branch December 4, 2023 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants