repr: make WMR type coercion more like SQL #23633
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sploiselle
force-pushed
the
wmr-numeric-coercion
branch
from
33ee994 to
29ba87a
Compare
|
Added a test case from Frank |
benesch
reviewed
Dec 3, 2023
| bar(x NUMERIC) as (SELECT sum(a) FROM y) | ||
| SELECT * FROM bar | ||
| ---- | ||
| NULL |
There was a problem hiding this comment.
Can we adjust this test case to test something more interesting than the base case? Ideally something that lets us "see" the coercion.
|
Oh, this is PR's insufficient––the logic on |
|
For the next PR, we'll want a corresponding change in the optimizer's typechecking pass, too, in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code on
mainprevented you from usingnumericvalues with different scales interchangeably, though SQL supports the operation.@frankmcsherry Would you mind coming up with a minimal test case? I tried for a few minutes but couldn't get the angle of attack just right.
Motivation
This PR fixes a recognized bug. Slack
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.WITH MUTUALLY RECURSIVEqueries. For example, you can now useNUMERICvalues of arbitrary scales.