Skip to content

adapter: add enable_mz_notices feature flag #23901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

aalexandrov
Copy link
Contributor

@aalexandrov aalexandrov commented Dec 14, 2023

Gate tracking of optimizer notices in the catalog behind a feature flag.

Design doc

Motivation

  • This PR adds a feature that has not yet been specified.

The bot in #23360 suggested to gate this behind a feature flag.

Tips for reviewer

  • The hard-coded default is true, otherwise we might not be able to pick all updates on the first deployment because the LD flag is synchronized after the bootstrap call.
  • Currently only gates the packing of retractions / insertions.
  • We should also add a change to misc/python/materialize/mzcompose/__init__.py, but as we saw earlier this week this doesn't quite work at the moment because regression tests picking up the last stable version and emit a warn if the DEFAULT_SYSTEM_PARAMETERS contain a parameter that is not supported by that version.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered.
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • This PR includes the following user-facing behavior changes:

@aalexandrov aalexandrov requested a review from a team as a code owner December 14, 2023 18:12
@aalexandrov aalexandrov enabled auto-merge (rebase) December 14, 2023 18:21
@aalexandrov aalexandrov force-pushed the enable_mz_notices branch 2 times, most recently from 213e665 to 440c742 Compare December 14, 2023 18:36
@aalexandrov aalexandrov self-assigned this Dec 14, 2023
@aalexandrov aalexandrov added A-ADAPTER Topics related to the ADAPTER layer A-compute Area: compute A-optimization Area: query optimization and transformation labels Dec 14, 2023
@aalexandrov aalexandrov force-pushed the enable_mz_notices branch 2 times, most recently from 2ecb80d to f440151 Compare December 15, 2023 09:11
Gate tracking of optimizer notices in the catalog behind a feature flag.
@aalexandrov aalexandrov merged commit 9a6ac0f into MaterializeInc:main Dec 15, 2023
@aalexandrov aalexandrov deleted the enable_mz_notices branch December 15, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer A-compute Area: compute A-optimization Area: query optimization and transformation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants