Change REHYDRATION TIME ESTIMATE to HYDRATION TIME ESTIMATE
#28138
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggevay
force-pushed
the
rehydration-to-hydration
branch
2 times, most recently
from
980aa25 to
2d9fff3
Compare
ggevay
force-pushed
the
rehydration-to-hydration
branch
from
2d9fff3 to
e366944
Compare
ggevay
force-pushed
the
rehydration-to-hydration
branch
from
e366944 to
9895bdb
Compare
Contributor
Author
|
The Nightly failures look unrelated, but I'll take a closer look tomorrow. |
morsapaes
approved these changes
Jul 10, 2024
Contributor
morsapaes
left a comment
morsapaes
left a comment
There was a problem hiding this comment.
The dbt bits look good to me. We'll need to cut a release in tandem with next week's release. @bobbyiliev
bobbyiliev
approved these changes
Jul 11, 2024
Contributor
Author
|
The Nightly failures are unrelated. Merging. |
5 tasks
sjwiesman
added a commit
that referenced
this pull request
Jul 19, 2024
### Motivation Release dbt-materialize v1.8.3 to pick up #28138 (review) ### Tips for reviewer <!-- Leave some tips for your reviewer, like: * The diff is much smaller if viewed with whitespace hidden. * [Some function/module/file] deserves extra attention. * [Some function/module/file] is pure code movement and only needs a skim. Delete this section if no tips. --> ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] This PR includes the following [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note): - <!-- Add release notes here or explicitly state that there are no user-facing behavior changes. -->
sjwiesman
added a commit
to sjwiesman/materialize
that referenced
this pull request
Jul 19, 2024
### Motivation Release dbt-materialize v1.8.3 to pick up MaterializeInc#28138 (review) ### Tips for reviewer <!-- Leave some tips for your reviewer, like: * The diff is much smaller if viewed with whitespace hidden. * [Some function/module/file] deserves extra attention. * [Some function/module/file] is pure code movement and only needs a skim. Delete this section if no tips. --> ### Checklist - [ ] This PR has adequate test coverage / QA involvement has been duly considered. ([trigger-ci for additional test/nightly runs](https://trigger-ci.dev.materialize.com/)) - [ ] This PR has an associated up-to-date [design doc](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/README.md), is a design doc ([template](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/design/00000000_template.md)), or is sufficiently small to not require a design. <!-- Reference the design in the description. --> - [ ] If this PR evolves [an existing `$T ⇔ Proto$T` mapping](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/command-and-response-binary-encoding.md) (possibly in a backwards-incompatible way), then it is tagged with a `T-proto` label. - [ ] If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label ([example](MaterializeInc/cloud#5021)). <!-- Ask in #team-cloud on Slack if you need help preparing the cloud PR. --> - [ ] This PR includes the following [user-facing behavior changes](https://github.com/MaterializeInc/materialize/blob/main/doc/developer/guide-changes.md#what-changes-require-a-release-note): - <!-- Add release notes here or explicitly state that there are no user-facing behavior changes. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with Marta and Nikhil here.
This changes the
REHYDRATION TIME ESTIMATEcluster option toHYDRATION TIME ESTIMATE. The parser still accepts the old version. Eventually, the old version will be completely removed, once users move to the new version. They'll move to the new syntax automatically when they start using a new dbt adapter version. Created an issue: https://github.com/MaterializeInc/database-issues/issues/8248I think I changed the dbt adapter (
misc/dbt-materialize/dbt/include/materialize/macros/ci/create_cluster.sql). @morsapaes, can you confirm?(I changed the
mz_internal.mz_cluster_schedules.refresh_hydration_time_estimatecolumn. This is inmz_internal, so should be fine.)(I haven't changed the protobuf for the catalog objects, but I think this is not externally visible anywhere.)
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.