envd: require explicit is_cc field in cluster size map
#30432
Merged
+177
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
def-
force-pushed
the
is-cc
branch
3 times, most recently
from
7e9a4b4 to
ed784b9
Compare
def-
force-pushed
the
is-cc
branch
4 times, most recently
from
fcedad9 to
636264d
Compare
def-
reviewed
Nov 12, 2024
benesch
commented
Nov 12, 2024
def-
force-pushed
the
is-cc
branch
2 times, most recently
from
5bd0c20 to
9b1658e
Compare
Rather than inferring the "cc"-ness of a cluster from its name. This will be important for self hosted Materialize, where customers will be able to install their own cluster size names. "cc"-ness defaults to true if not explicitly disabled, since "cc" clusters get modern behavior that we want all self-hosted clustrs to get. Also, make it possible to disable using disk for a given size by setting the disk limit to 0, even for sizes marked as "cc", to support users that will be running Materialize on nodes without local disks.
antiguru
approved these changes
Nov 13, 2024
alex-hunt-materialize
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than inferring the "cc"-ness of a cluster from its name. This will be important for self hosted Materialize, where customers will be able to install their own cluster size names. "cc"-ness defaults to true if not explicitly disabled, since "cc" clusters get modern behavior that we want all self-hosted clustrs to get.
Also, make it possible to disable using disk for a given size by setting the disk limit to 0, even for sizes marked as "cc", to support users that will be running Materialize on nodes without local disks.
Motivation
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.