[dnm] test RenderPlan with LIR introspection #30532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit moves the `RustType` impl for `LirId` from a random place to where the `LirId` type is defined.
This commit extracts the `FlatPlan` structural invariants previously only defined in documentation into the type system. A `FlatPlan` now consists of a sequence of `BindStage`s that define the bindings in the plan, and a final `LetFreePlan` that's free of bindings.
This commit cleans up all the code around the render plan. It updates comments in both `flat_plan.rs` and rendering, and renames the `FlatPlan` types to better describe their current roles. For example, the plan isn't fully flat anymore, so calling it `FlatPlan` is misleading. Specifically, the following types were renamed are: * `FlatPlan` -> `RenderPlan` * `FlatPlanStep` -> `Node` * `FlatPlanNode` -> `Expr`
This commit renames the `flat_plan` module to `render_plan`, following the rename from `FlatPlan` to `RenderPlan` in the previous commit.
This commit changes `RenderPlan`'s `From<Plan>` impl into a `TryFrom` impl and adds documentation about the shape of `Plan` expected for the `try_from` to succeed. Co-authored-by: Frank McSherry <[email protected]>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.