Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: Allow mz_system to grant to builtin role #30538

Closed
wants to merge 1 commit into from

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Nov 18, 2024

Previously, we did not allow anyone to grant a privilege to a builtin role. There are some use cases, such as exposing metrics/data to mz_support, where it would be useful to grant additional privileges to builtin roles. This commit addresses the issue by allowing only mz_system to grant privileges to builtin roles.

Motivation

This PR adds a feature that has not yet been specified.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

Previously, we did not allow anyone to grant a privilege to a builtin
role. There are some use cases, such as exposing metrics/data to
mz_support, where it would be useful to grant additional privileges to
builtin roles. This commit addresses the issue by allowing only
mz_system to grant privileges to builtin roles.
@jkosh44 jkosh44 closed this Nov 19, 2024
@jkosh44 jkosh44 deleted the system-role-grants branch November 19, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant