Skip to content

Conversation

@bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Nov 20, 2024

Including "source tables". (But not subsources - I think the syntax there is less obvious, and IIUC they're already on their way out.)

Motivation

Followup to #30355 -- see that PR for more details.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@bkirwi bkirwi marked this pull request as ready for review November 20, 2024 21:33
@bkirwi bkirwi requested a review from a team as a code owner November 20, 2024 21:33
@bkirwi bkirwi requested review from a team and ParkMyCar November 20, 2024 21:33
Copy link
Contributor

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bkirwi bkirwi merged commit 8c7eb9c into MaterializeInc:main Nov 21, 2024
81 checks passed
@bkirwi bkirwi deleted the partition-by-2 branch November 21, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants