Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore introspection sources #30620

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Restore introspection sources #30620

merged 1 commit into from
Nov 27, 2024

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Nov 25, 2024 •
edited
Loading

This reverts commit d3bea77, reversing
changes made to 0883e66.

Motivation

This PR adds a known-desirable feature.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@jkosh44 jkosh44 force-pushed the restore-introspection-sources branch 5 times, most recently from da5efa4 to 23feb5d Compare November 25, 2024 19:55
@jkosh44 jkosh44 mentioned this pull request Nov 25, 2024
Merged
5 tasks
@jkosh44 jkosh44 force-pushed the restore-introspection-sources branch 3 times, most recently from 1db6801 to c62466c Compare November 26, 2024 20:31
@jkosh44
Revert "Merge pull request MaterializeInc#30393 from teskje/disable-n…
f52e4d7 
…ew-introspection-sources"

This reverts commit d3bea77, reversing
changes made to 0883e66.
@jkosh44 jkosh44 force-pushed the restore-introspection-sources branch from c62466c to f52e4d7 Compare November 27, 2024 19:39
@jkosh44 jkosh44 requested review from mgree and teskje November 27, 2024 19:40
@jkosh44 jkosh44 marked this pull request as ready for review November 27, 2024 19:40
@jkosh44 jkosh44 requested review from a team as code owners November 27, 2024 19:40
@jkosh44 jkosh44 requested a review from ParkMyCar November 27, 2024 19:40
@jkosh44
Copy link
Contributor Author

jkosh44 commented Nov 27, 2024 •
edited
Loading

@teskje feel free to make changes to this and merge tomorrow without me if you want to make the release cut-off.

ParkMyCar
ParkMyCar approved these changes Nov 27, 2024
View reviewed changes
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkosh44
Copy link
Contributor Author

jkosh44 commented Nov 27, 2024

@teskje feel free to make changes to this and merge tomorrow without me if you want to make the release cut-off.

Actually, once it makes it through most of Nightly's I'll just merge it today. You can revert tomorrow if you think there's any issues.

@jkosh44 jkosh44 merged commit d073a1e into MaterializeInc:main Nov 27, 2024
214 of 229 checks passed
@jkosh44 jkosh44 deleted the restore-introspection-sources branch November 27, 2024 21:45
@teskje teskje mentioned this pull request Nov 28, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ParkMyCar ParkMyCar ParkMyCar approved these changes

@mgree mgree Awaiting requested review from mgree

@teskje teskje Awaiting requested review from teskje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkosh44 @ParkMyCar