Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some old feature flags around window functions #30641

Merged

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Nov 27, 2024

Remove:
enable_value_window_function_fusion
enable_window_aggregation_fusion
enable_reduce_unnest_list_fusion

These features are on in all envs since more than a month, and there hasn't been any complaints about them.

Motivation

  • This PR removes old feature flags.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

enable_value_window_function_fusion
enable_window_aggregation_fusion
enable_reduce_unnest_list_fusion
@ggevay ggevay added A-optimization Area: query optimization and transformation A-CLUSTER Topics related to the CLUSTER layer labels Nov 27, 2024
@ggevay ggevay requested a review from petrosagg November 27, 2024 18:11
@ggevay ggevay requested review from a team as code owners November 27, 2024 18:11
@ggevay ggevay requested a review from ParkMyCar November 27, 2024 18:11
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ggevay ggevay merged commit 101bc31 into MaterializeInc:main Nov 28, 2024
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CLUSTER Topics related to the CLUSTER layer A-optimization Area: query optimization and transformation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants