Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapter: convert panic to terminate #30681

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Dec 2, 2024

Motivation

This PR fixes a previously unreported bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@jkosh44 jkosh44 marked this pull request as ready for review December 2, 2024 15:10
@jkosh44 jkosh44 requested a review from a team as a code owner December 2, 2024 15:10
@jkosh44 jkosh44 requested a review from ParkMyCar December 2, 2024 15:10
@jkosh44 jkosh44 enabled auto-merge (squash) December 2, 2024 15:35
@jkosh44 jkosh44 merged commit 56a578b into MaterializeInc:main Dec 2, 2024
81 checks passed
@jkosh44 jkosh44 deleted the unwrap-or-terminate branch December 2, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants