Skip to content

slt: Undo downgrade of SLT submodule #31083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2025
Merged

slt: Undo downgrade of SLT submodule #31083

merged 1 commit into from
Jan 17, 2025

Conversation

def-
Copy link
Contributor

@def- def- commented Jan 17, 2025

Seems to have happened accidentally in #31065

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def-
slt: Undo downgrade of SLT submodule
03282be 
Seems to have happened accidentally in MaterializeInc#31065
@def- def- requested review from jkosh44 and ggevay January 17, 2025 10:08
@def- def- enabled auto-merge January 17, 2025 10:08
ggevay
ggevay approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry! I have no idea how this happened.

@def-
Copy link
Contributor Author

def- commented Jan 17, 2025

Git submodules are just bad UX I think. When you run a normal git pull etc. they are not synced.

@def- def- merged commit f1e1e1e into MaterializeInc:main Jan 17, 2025
13 of 24 checks passed
@def- def- deleted the pr-sqlite-submodule-revert branch January 17, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggevay ggevay ggevay approved these changes

@jkosh44 jkosh44 Awaiting requested review from jkosh44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @ggevay