Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source: Fix key-value load gen w/o primary export #31134

Merged

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Jan 21, 2025

This commit fixes the key-value load generator source when the primary
export is removed via the force_source_table_syntax flag.

Fixes #MaterializeInc/database-issues/issues/8904

Motivation

This PR fixes a recognized bug.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@jkosh44 jkosh44 force-pushed the force-key-value-load-gen-source branch 2 times, most recently from c4d2649 to c054be3 Compare January 22, 2025 20:09
@jkosh44 jkosh44 marked this pull request as ready for review January 22, 2025 20:33
@jkosh44 jkosh44 requested a review from a team as a code owner January 22, 2025 20:33
@jkosh44 jkosh44 requested review from aljoscha and petrosagg January 22, 2025 20:33
This commit fixes the key-value load generator source when the primary
export is removed via the force_source_table_syntax flag.

Fixes #MaterializeInc/database-issues/issues/8904
@jkosh44 jkosh44 force-pushed the force-key-value-load-gen-source branch from c054be3 to 6c9d7d8 Compare January 23, 2025 15:40
Copy link
Contributor

@aljoscha aljoscha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I like this, but here we are. 😅 (of course not because of anything you did wrong)

I think this is a good fix in our situation, though, and will help unblock the migration work needed for table-from-source syntax!

@jkosh44 jkosh44 merged commit bfd7d42 into MaterializeInc:main Jan 24, 2025
240 checks passed
@jkosh44 jkosh44 deleted the force-key-value-load-gen-source branch January 24, 2025 16:49
antiguru pushed a commit to antiguru/materialize that referenced this pull request Jan 24, 2025
This commit fixes the key-value load generator source when the primary
export is removed via the force_source_table_syntax flag.

Fixes #MaterializeInc/database-issues/issues/8904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants