Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename sql/src/plan/expr.rs to hir.rs #31142

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Jan 22, 2025

A continuation of #31124. We have lots of exprs throughout our codebase, so it's better to explicitly mention HIR.

Also, slightly tweaks the comment at the top of the file.

Motivation

  • This PR refactors existing code.

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay requested review from a team as code owners January 22, 2025 14:20
@ggevay ggevay requested a review from jkosh44 January 22, 2025 14:20
@ggevay ggevay added the A-ADAPTER Topics related to the ADAPTER layer label Jan 22, 2025
@ggevay ggevay enabled auto-merge January 22, 2025 14:45
@ggevay ggevay merged commit 32434f7 into MaterializeInc:main Jan 22, 2025
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants