adapter: Fix startup parameter default values #31166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkosh44
force-pushed
the
ld-investigate
branch
2 times, most recently
from
d71c4fa to
f42ff63
Compare
There are some server configuration parameters that we need during startup, before the catalog has been fully opened. To get the current value we manually look at the current value in LaunchDarkly (which is confusingly returned as `None` if it matches the default value in the code), then we manually look in the catalog, then we manually look in the server parameter default override CLI arg map. Previously, For some of the parameters, if we weren't able to find the value in any of those places, then we hard-code in the value false. This is not correct, and instead we should fall back to their default value, which is sometimes true. This commit fixes the issue by falling back to their default values.
jkosh44
force-pushed
the
ld-investigate
branch
from
f42ff63 to
2e538b1
Compare
jkosh44
changed the title
|
This is potentially now a confusing log message, but it does seem to work |
Arguably we should split the log line to have "CLI default" and "code default" but don't go back through CI just for that. |
antiguru
pushed a commit
to antiguru/materialize
that referenced
this pull request
Jan 24, 2025
There are some server configuration parameters that we need during startup, before the catalog has been fully opened. To get the current value we manually look at the current value in LaunchDarkly (which is confusingly returned as `None` if it matches the default value in the code), then we manually look in the catalog, then we manually look in the server parameter default override CLI arg map. Previously, for some of the parameters, if we weren't able to find the value in any of those places, then we hard-code in the value false. This is not correct, and instead we should fall back to their default value, which is sometimes true. This commit fixes the issue by falling back to their default values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some server configuration parameters that we need during
startup, before the catalog has been fully opened. To get the current
value we manually look at the current value in LaunchDarkly (which is
confusingly returned as
Noneif it matches the default value in thecode), then we manually look in the catalog, then we manually look in
the server parameter default override CLI arg map.
Previously, for some of the parameters, if we weren't able to find the
value in any of those places, then we hard-code in the value false.
This is not correct, and instead we should fall back to their default
value, which is sometimes true. This commit fixes the issue by falling
back to their default values.
Motivation
This PR fixes a previously unreported bug.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.