Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch dataflow fragments to columnar #31186

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Switch dataflow fragments to columnar #31186

merged 2 commits into from
Jan 31, 2025
+212 −144

Conversation

antiguru
Copy link
Member

@antiguru antiguru commented Jan 24, 2025 •
edited
Loading

Switch arrange formation and the linear join preparation phase to use columnar data on dataflow edges.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@antiguru antiguru requested review from aljoscha, jkosh44, a team and benesch as code owners January 24, 2025 19:25
@antiguru antiguru marked this pull request as draft January 24, 2025 19:25
@antiguru antiguru force-pushed the unary_faillable_columnar branch 4 times, most recently from 704ddb1 to f2e0782 Compare January 29, 2025 14:53
@antiguru antiguru marked this pull request as ready for review January 29, 2025 14:56
@antiguru antiguru requested review from teskje and frankmcsherry and removed request for a team, aljoscha, benesch and jkosh44 January 29, 2025 14:56
frankmcsherry
frankmcsherry approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@frankmcsherry frankmcsherry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These all make sense. I have to puzzle out which things are columnar and which are not (these do some conversion, but I'm missing the larger picture so far, but trust that it will come together).

src/compute/src/render/context.rs Outdated Show resolved Hide resolved
src/compute/src/render/context.rs Outdated Show resolved Hide resolved
@antiguru
Switch some dataflow fragments to columnar
b521f2a 
Change the dataflow fragment for `specialized_arrange` and in the linear
join preparation phase to use columnar data on edges.

Signed-off-by: Moritz Hoffmann <[email protected]>

# Conflicts:
#	src/repr/src/row.rs
#	src/storage-operators/Cargo.toml
@antiguru
Address comments
c17cab2 
Signed-off-by: Moritz Hoffmann <[email protected]>
@antiguru antiguru force-pushed the unary_faillable_columnar branch from f2e0782 to c17cab2 Compare January 31, 2025 11:06
@antiguru antiguru enabled auto-merge (squash) January 31, 2025 11:06
@antiguru antiguru merged commit 7ecf0d9 into MaterializeInc:main Jan 31, 2025
78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankmcsherry frankmcsherry frankmcsherry approved these changes

@teskje teskje Awaiting requested review from teskje

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antiguru @frankmcsherry