Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: Update expr cache design doc #31215

Merged
merged 1 commit into from
Jan 28, 2025
Merged

doc: Update expr cache design doc #31215

merged 1 commit into from
Jan 28, 2025

Conversation

jkosh44
Copy link
Contributor

@jkosh44 jkosh44 commented Jan 28, 2025

This commit updates the expression cache design doc to match the changes from 5df1932.

Motivation

This PR refactors existing code.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@jkosh44
doc: Update expr cache design doc
e93b9a4 
This commit updates the expression cache design doc to match the
changes from 5df1932.
@jkosh44 jkosh44 requested a review from ggevay January 28, 2025 16:06
@jkosh44 jkosh44 requested a review from a team as a code owner January 28, 2025 16:06
@jkosh44 jkosh44 requested a review from aljoscha January 28, 2025 16:06
@jkosh44 jkosh44 enabled auto-merge (squash) January 28, 2025 16:06
ggevay
ggevay approved these changes Jan 28, 2025
View reviewed changes
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkosh44 jkosh44 merged commit c46773e into MaterializeInc:main Jan 28, 2025
81 checks passed
@jkosh44 jkosh44 deleted the expr-cache-design branch January 28, 2025 16:54
jkosh44 added a commit to jkosh44/materialize that referenced this pull request Jan 28, 2025
@jkosh44
doc: Update expr cache design doc (MaterializeInc#31215)
67d8816 
This commit updates the expression cache design doc to match the changes
from 5df1932.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggevay ggevay ggevay approved these changes

@aljoscha aljoscha Awaiting requested review from aljoscha aljoscha is a code owner automatically assigned from MaterializeInc/adapter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkosh44 @ggevay