Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: enable source replication, make it configurable #31227

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

storage: enable source replication, make it configurable #31227

wants to merge 5 commits into from

Conversation

aljoscha
Copy link
Contributor

Version of #30003 with a dyncfg for enabling/disabling multi-replica sources

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@aljoscha aljoscha requested review from a team as code owners January 29, 2025 14:08
@aljoscha aljoscha requested a review from ParkMyCar January 29, 2025 14:08
@aljoscha aljoscha force-pushed the active-replication-with-cfg branch from a562f9b to f8c49f7 Compare February 3, 2025 13:59
@aljoscha aljoscha force-pushed the active-replication-with-cfg branch from f8c49f7 to 3e761d9 Compare February 3, 2025 16:06
ParkMyCar
ParkMyCar approved these changes Feb 6, 2025
View reviewed changes
Copy link
Member

@ParkMyCar ParkMyCar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

def-
def- reviewed Feb 6, 2025
View reviewed changes
Copy link
Contributor

@def- def- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test changes lgtm, I triggered a nightly run: https://buildkite.com/materialize/nightly/builds/11070

@def-
Copy link
Contributor

def- commented Feb 6, 2025

I'm a bit confused by the data ingest error: https://buildkite.com/materialize/nightly/builds/11070#0194dc61-63a3-4e71-b78a-7dad5aa1bac1

psycopg.errors.InternalError_: cannot create source in cluster with more than one replica

I thought that shouldn't happen anymore since we enable multi-cluster replication now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@def- def- def- left review comments

@ParkMyCar ParkMyCar ParkMyCar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aljoscha @def- @ParkMyCar @petrosagg