Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

query_history: Reduce amount of indexed data down to 1 day #31250

Merged
merged 3 commits into from
Jan 31, 2025

Conversation

ParkMyCar
Copy link
Member

As it says in the title!

Motivation

Fixes https://github.com/MaterializeInc/database-issues/issues/8938

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ParkMyCar ParkMyCar requested a review from a team as a code owner January 30, 2025 21:33
@ParkMyCar ParkMyCar requested a review from aljoscha January 30, 2025 21:33
Copy link
Contributor

@JLDLaughlin JLDLaughlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@ParkMyCar ParkMyCar enabled auto-merge (squash) January 30, 2025 21:35
@SangJunBak
Copy link
Contributor

SangJunBak commented Jan 30, 2025

In this PR, would we be able to add access: vec![SUPPORT_SELECT, ANALYTICS_SELECT, MONITOR_REDACTED_SELECT, MONITOR_SELECT], to mz_prepared_statement_history or just [PUBLIC_SELECT]? Otherwise we aren't able to join MZ_RECENT_SQL_TEXT_REDACTED, mz_statement_execution_history_redacted, and mz_prepared_statement_history for mz_support users. Alternatively, we can create a new view called MZ_ACTIVITY_LOG_THINNED_REDACTED that hides the error_message

@ParkMyCar ParkMyCar disabled auto-merge January 30, 2025 22:14
We need this to use a temporal filter on activity log information. We're not exposing customer data in this relation so there's no reason to keep the restriction so tight.
@SangJunBak
Copy link
Contributor

Talked it over with Parker and he agreed. Added 46b80bf (#31250)

@ParkMyCar ParkMyCar enabled auto-merge (squash) January 30, 2025 22:33
@SangJunBak SangJunBak requested a review from a team as a code owner January 31, 2025 00:41
@SangJunBak SangJunBak force-pushed the query_history/index-length branch from cdde4d5 to 98a4453 Compare January 31, 2025 04:55
@ParkMyCar ParkMyCar merged commit 2b14c26 into MaterializeInc:main Jan 31, 2025
79 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants