Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] Correction buffer metrics #31262

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[wip] Correction buffer metrics #31262

wants to merge 3 commits into from

Conversation

bkirwi
Copy link
Contributor

@bkirwi bkirwi commented Jan 31, 2025

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@bkirwi bkirwi force-pushed the correction-metrics branch 3 times, most recently from 9956cb9 to eee5b70 Compare January 31, 2025 18:24
bkirwi added 2 commits January 31, 2025 15:37
@bkirwi
Add new metrics for the correction buffer
d024e9c
@bkirwi
Advance the frontier based on the batch descriptions
3fa1e98 
This has a few advantages:
- We can advance the since more aggressively, because the write frontier
  is generally in advance of the since. (Though if it's not, no harm
  done.)
- We're guaranteed that when we stamp out a batch it will never change,
  which makes it a good time to check our invariants.
@bkirwi bkirwi force-pushed the correction-metrics branch from eee5b70 to 3fa1e98 Compare January 31, 2025 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bkirwi