Skip to content

mysql old syntax test: Invisible columns supported#31302

Merged
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-invis
Feb 6, 2025
Merged

mysql old syntax test: Invisible columns supported#31302
def- merged 1 commit intoMaterializeInc:mainfrom
def-:pr-invis

Conversation

@def-
Copy link
Contributor

@def- def- commented Feb 6, 2025

Noticed in https://buildkite.com/materialize/nightly/builds/11064#0194d8ae-2f77-487b-b6fc-ec78a95aaaef

Nightly run to verify: https://buildkite.com/materialize/nightly/builds/11066

Follow-up to #31239

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- requested a review from martykulma February 6, 2025 07:57
@def- def- enabled auto-merge February 6, 2025 07:58
Copy link
Contributor

@martykulma martykulma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this one, thanks @def-

@def- def- merged commit 24b027b into MaterializeInc:main Feb 6, 2025
10 checks passed
@def- def- deleted the pr-invis branch February 6, 2025 12:11
@def-
Copy link
Contributor Author

def- commented Feb 6, 2025

No worries, that's why we auto-detect such comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants