Skip to content

tests: 2 replicas in more places #32203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

tests: 2 replicas in more places #32203

wants to merge 1 commit into from
+224 −191

Conversation

def-
Copy link
Contributor

@def- def- commented Apr 15, 2025 •
edited
Loading

Fixes https://github.com/MaterializeInc/database-issues/issues/9106

I'm starting to think that we can't land this since it makes tests much slower. I'll have to come up with a smarter solution, maybe only switching to 2 replicas in nightly.

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@def- def- force-pushed the pr-more-2-replica branch 12 times, most recently from 99f5c6f to b4070c9 Compare April 16, 2025 06:44
@def- def- requested a review from aljoscha April 16, 2025 06:51
@def- def- marked this pull request as ready for review April 16, 2025 06:52
@def- def- requested review from ggevay and a team as code owners April 16, 2025 06:52
@def- def- force-pushed the pr-more-2-replica branch from b4070c9 to 7c035d0 Compare April 16, 2025 08:23
@aljoscha
Copy link
Contributor

So should I review or hold off for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljoscha aljoscha Awaiting requested review from aljoscha

@ggevay ggevay Awaiting requested review from ggevay ggevay is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@def- @aljoscha