[v0.147 only] cargo test: Disable test_persist_open #33625
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My interpretation is that following MaterializeInc@4b63360 we have a migration even when the version number doesn't change (v74 -> v74). This test specifically tests that the catalog stays the same, but this invariant isn't true anymore with this change.
def-
added
the
self-managed-backport-v25.2
|
Sorry about that! I think it was probably still the right call given the predicament we were in, but I didn't realize we had this test. |
jubrad
approved these changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My interpretation is that following
4b63360 we have a migration even when the version number doesn't change (v74 -> v74). This test specifically tests that the catalog stays the same, but this invariant isn't true anymore with this change.
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.