Fix balancerd compose tests [wip] #33656
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubrad
force-pushed
the
fix-balancerd-compose-tests-wip
branch
from
7abdcb7 to
ee7c6c9
Compare
jubrad
commented
Sep 23, 2025
Comment on lines
+137
to
+139
| "networks": { | ||
| "mzcompose": {"ipam": {"config": [{"subnet": "10.10.0.0/24"}]}} | ||
| }, |
There was a problem hiding this comment.
Honestly I don't think it's a great idea to put this in here, but it needs to be defined at this level, open to suggestions
jubrad
force-pushed
the
fix-balancerd-compose-tests-wip
branch
from
ba5612d to
e4780e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.