Skip to content

adapter: fix monotonicity information for tables of sources #33660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2025
Merged

adapter: fix monotonicity information for tables of sources #33660

merged 1 commit into from
Sep 22, 2025
+36 −213

Conversation

petrosagg
Copy link
Contributor

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@petrosagg petrosagg force-pushed the table-from-source-monotonicity branch from 112a819 to e71e2d7 Compare September 22, 2025 08:54
@petrosagg petrosagg force-pushed the table-from-source-monotonicity branch from e71e2d7 to 583d407 Compare September 22, 2025 08:55
@petrosagg petrosagg marked this pull request as ready for review September 22, 2025 09:10
@petrosagg petrosagg requested a review from a team as a code owner September 22, 2025 09:10
ggevay
ggevay approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@ggevay ggevay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@petrosagg petrosagg merged commit 702a0c9 into MaterializeInc:main Sep 22, 2025
125 checks passed
@petrosagg petrosagg deleted the table-from-source-monotonicity branch September 22, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggevay ggevay ggevay approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@petrosagg @ggevay