storage: report statistics only for ingestion exports #33661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
commented
Sep 21, 2025
petrosagg
force-pushed
the
export-only-statistics
branch
from
56d5d8f to
45cc40e
Compare
petrosagg
requested review from
ggevay and
martykulma
and removed request for
ggevay
petrosagg
force-pushed
the
export-only-statistics
branch
from
45cc40e to
a9b2cb6
Compare
Makes it so `mz_source_statistics_raw` only records information for actual source exports. Then, `mz_source_statistics` includes everything in the raw table and an aggregated view over the entire source. The aggregation is defined as a simple SQL query instead of each source managing it in its Rust implementation. Signed-off-by: Petros Angelatos <[email protected]>
petrosagg
force-pushed
the
export-only-statistics
branch
from
a9b2cb6 to
ca79be2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so
mz_source_statistics_rawonly records information for actual source exports. Then,mz_source_statisticsincludes everything in the raw table and an aggregated view over the entire source. The aggregation is defined as a simple SQL query instead of each source managing it in its Rust implementation.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$Tmapping (possibly in a backwards-incompatible way), then it is tagged with aT-protolabel.