[persist] Add a safely serializable metadata map to some Persist structs #34093
+161
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkirwi
force-pushed
the
metadata-map
branch
3 times, most recently
from
bf57aaf to
df8b88f
Compare
bkirwi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This future-proofs Persist slightly by adding a new metadata map to some core structures. This map can have new key and value types added to it without breaking compatibility, since the data will be safely roundtripped by any version that knows about the map.
Motivation
Final bullet in https://github.com/MaterializeInc/database-issues/issues/9870